Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- isLogin이 localStorage값을 참조해서 ssr에서 사용 불가능 해서 state로 만듦
- 이미지 전송 로직 수정 - title이 길어지는 경우 대응
- 경과된 시간을 string 값으로 return 해주는 함수
jyh0521
approved these changes
Aug 19, 2024
|
|
||
| export type OrderOption = "like" | "recent"; | ||
|
|
||
| interface GetArticlesProps { |
There was a problem hiding this comment.
이 타입이 api 요청을 보낼때 매개변수 타입으로 쓰인다면, GetArticlesParams 같은 이름도 추천드립니다.
| password: string; | ||
| } | ||
|
|
||
| export interface SignUpUserProps extends LogInUserProps { |
Comment on lines
+28
to
+30
| localStorage.setItem("access_token", accessToken); | ||
| localStorage.setItem("refresh_token", refreshToken); | ||
| window.location.href = "/"; |
There was a problem hiding this comment.
api 요청을 보내는 부분에서는 api 요청만 보내고 이런 로직들은 훅으로 만들어서 api 호출할때 추가해주시는 것을 추천드립니다. 각 함수의 역할을 분리해주는 것이죠!
Comment on lines
+71
to
+72
| axiosInstance.interceptors.request.use(onRequest); | ||
| axiosInstance.interceptors.response.use((response: AxiosResponse) => response, onErrorResponse); |
| const path = router.pathname; | ||
| export default function GlobalNavBar() { | ||
| const { pathname } = useRouter(); | ||
| const isMain = pathname === "/" ? true : false; |
There was a problem hiding this comment.
이 변수는 const isMain = pathname === "/" 로 줄일 수 있을 것 같습니다.
|
|
||
| onChangeComments((prevComments) => [postedComment, ...prevComments]); | ||
| } catch (error) { | ||
| console.log(error); |
There was a problem hiding this comment.
error 로그를 찍을때, console.error 사용도 추천드립니다.
Comment on lines
+16
to
+18
| if (id === null) { | ||
| throw new Error("id 값이 올바르지 않습니다."); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
사이트 배포 링크
요구사항
피그마 링크
기본 요구사항
체크리스트 (기본)
상품 등록 페이지
상품 상세 페이지
피드백 반영
추가 예정 사항
주요 변경사항
멘토에게